Bug 181626 - [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
Summary: [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-12 18:33 PST by Wenson Hsieh
Modified: 2018-01-12 21:32 PST (History)
8 users (show)

See Also:

Attachments
Patch (3.59 KB, patch)
2018-01-12 19:04 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (4.78 KB, patch)
2018-01-12 20:48 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-01-12 18:33:44 PST 
WKAttachmentTests.ChangeAttachmentDataUpdatesWithInPlaceDisplay
WKAttachmentTests.InPlaceVideoAttachmentInsertionWithinList

Regressed after r226915. Test expectations just need to be rebaselined.
Comment 1 Wenson Hsieh 2018-01-12 19:04:33 PST 
Created attachment 331270 [details]
Patch
Comment 2 Wenson Hsieh 2018-01-12 20:48:49 PST 
Created attachment 331272 [details]
Patch
Comment 3 Joseph Pecoraro 2018-01-12 20:56:45 PST 
Comment on attachment 331272 [details]
Patch

r=me
Comment 4 Wenson Hsieh 2018-01-12 21:08:09 PST 
Thanks for the review!
Comment 5 WebKit Commit Bot 2018-01-12 21:31:01 PST 
Comment on attachment 331272 [details]
Patch

Clearing flags on attachment: 331272

Committed r226935: <https://trac.webkit.org/changeset/226935>
Comment 6 WebKit Commit Bot 2018-01-12 21:31:02 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-01-12 21:32:37 PST 
<rdar://problem/36492021>