Bug 181607

Summary: Web Inspector: Support JSX (React) syntax highlighting
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] JSX Before
none
[IMAGE] JSX After
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2018-01-12 12:06:44 PST
Support JSX (React) syntax highlighting Common file extension: .jsx Common mime type: text/jsx CodeMirror has a mode for this that we can include.
Attachments
[IMAGE] JSX Before (388.04 KB, image/png)
2018-01-12 12:09 PST, Joseph Pecoraro 		no flags
Details
[IMAGE] JSX After (406.48 KB, image/png)
2018-01-12 12:09 PST, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix (9.26 KB, patch)
2018-01-12 12:09 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2018-01-12 12:07:17 PST
<rdar://problem/36442564>
Joseph Pecoraro
Comment 2 2018-01-12 12:09:04 PST
Created attachment 331221 [details] [IMAGE] JSX Before
Joseph Pecoraro
Comment 3 2018-01-12 12:09:14 PST
Created attachment 331222 [details] [IMAGE] JSX After
Joseph Pecoraro
Comment 4 2018-01-12 12:09:35 PST
Created attachment 331223 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 5 2018-01-12 12:12:27 PST
Comment on attachment 331223 [details] [PATCH] Proposed Fix Hmm, the XHR fetched .jsx text/jsx files don't look syntax highlighted. Let me check on that.
Joseph Pecoraro
Comment 6 2018-01-12 12:15:01 PST
Comment on attachment 331223 [details] [PATCH] Proposed Fix Oh it does, I was just using the wrong browser window.
Blaze Burg
Comment 7 2018-01-12 12:19:51 PST
Comment on attachment 331223 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 8 2018-01-12 13:03:27 PST
Comment on attachment 331223 [details] [PATCH] Proposed Fix Clearing flags on attachment: 331223 Committed r226909: <https://trac.webkit.org/changeset/226909>
WebKit Commit Bot
Comment 9 2018-01-12 13:03:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.