Bug 181594

Summary:

[EME] Add layout test for the MSE playback of ClearKey encrypted audio and video

Product:

WebKit

Reporter:

Yacine Bandou <bandou.yacine>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, commit-queue, jer.noble, lforschler, olivier.blin, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Yacine Bandou

Reported 2018-01-12 07:58:04 PST

Add new layout tests in order to test the playback of ClearKey encrypted content: - clearKey-cenc-audio-playback-mse : test the MSE playback of ClearKey encrypted audio track wich use the full-sample encryption. - clearKey-cenc-video-playback-mse : test the MSE playback of ClearKey encrypted video track wich use the sub-sample encryption scheme.

Attachments
Patch (289.50 KB, patch) 2018-01-12 09:41 PST, Yacine Bandou	no flags	Details Formatted Diff Diff
Patch (289.50 KB, patch) 2018-01-15 07:18 PST, Yacine Bandou	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yacine Bandou

Comment 1 2018-01-12 09:41:08 PST

Created attachment 331208 [details] Patch

Xabier Rodríguez Calvar

Comment 2 2018-01-15 00:58:05 PST

Comment on attachment 331208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331208&action=review > LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html:33 > + let ms = new MediaSourceLoaderSimple(video); You can probably use const here. > LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html:17 > + let emeHandler = new EncryptedMediaHandler(video, videoConf); You can probably use const here. > LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html:33 > + let ms = new MediaSourceLoaderSimple(video); Ditto. > LayoutTests/platform/wpe/TestExpectations:1132 > +webkit.org/b/180080 media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html [ Crash ] ?

Yacine Bandou

Comment 3 2018-01-15 06:45:55 PST

(In reply to Xabier Rodríguez Calvar from comment #2) > Comment on attachment 331208 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=331208&action=review > > > LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html:33 > > + let ms = new MediaSourceLoaderSimple(video); > > You can probably use const here. Yes > > > LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html:17 > > + let emeHandler = new EncryptedMediaHandler(video, videoConf); > > You can probably use const here. Yes > > > LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html:33 > > + let ms = new MediaSourceLoaderSimple(video); > > Ditto. Yes > > > LayoutTests/platform/wpe/TestExpectations:1132 > > +webkit.org/b/180080 media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html [ Crash ] > > ? Crash because the content follow the full-sample encryption, thus the subSamplesBuffer is nul So we crash in this line: >Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:240 GstMapInfo subSamplesMap; gboolean subsamplesBufferMapped = gst_buffer_map(subSamplesBuffer, &subSamplesMap, GST_MAP_READ);

Yacine Bandou

Comment 4 2018-01-15 07:18:12 PST

Created attachment 331335 [details] Patch

WebKit Commit Bot

Comment 5 2018-01-16 00:16:38 PST

Comment on attachment 331335 [details] Patch Clearing flags on attachment: 331335 Committed r226966: <https://trac.webkit.org/changeset/226966>

WebKit Commit Bot

Comment 6 2018-01-16 00:16:39 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2018-01-16 00:17:28 PST

<rdar://problem/36536151>

Note You need to log in before you can comment on or make changes to this bug.