Bug 181592

Summary: Put fetch Request.keepalive behind a runtime flag
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, esprehn+autocc, ews-watchlist, kondapallykalyan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=181587
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews102 for mac-sierra
none
Fixing WK1
none
Fixing Win
none
Fixing Win
none
Fixing Win
none
Fixing Win none

youenn fablet
Reported 2018-01-12 07:11:27 PST
Implementation is not complete yet
Attachments
Patch (7.51 KB, patch)
2018-01-12 07:15 PST, youenn fablet
no flags
Patch (8.70 KB, patch)
2018-01-12 07:20 PST, youenn fablet
no flags
Archive of layout-test-results from ews102 for mac-sierra (2.19 MB, application/zip)
2018-01-12 08:23 PST, EWS Watchlist
no flags
Fixing WK1 (18.10 KB, patch)
2018-01-12 08:59 PST, youenn fablet
no flags
Fixing Win (18.27 KB, patch)
2018-01-17 10:01 PST, youenn fablet
no flags
Fixing Win (19.69 KB, patch)
2018-01-17 10:30 PST, youenn fablet
no flags
Fixing Win (18.62 KB, patch)
2018-01-17 11:20 PST, youenn fablet
no flags
Fixing Win (19.26 KB, patch)
2018-01-17 12:14 PST, youenn fablet
no flags
youenn fablet
Comment 1 2018-01-12 07:15:40 PST
youenn fablet
Comment 2 2018-01-12 07:20:35 PST
EWS Watchlist
Comment 3 2018-01-12 08:23:53 PST
Comment on attachment 331201 [details] Patch Attachment 331201 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6050086 New failing tests: imported/w3c/web-platform-tests/fetch/api/request/request-keepalive.html
EWS Watchlist
Comment 4 2018-01-12 08:23:55 PST
Created attachment 331203 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
youenn fablet
Comment 5 2018-01-12 08:59:02 PST
Created attachment 331205 [details] Fixing WK1
Chris Dumez
Comment 6 2018-01-17 09:24:29 PST
Comment on attachment 331205 [details] Fixing WK1 Please check why win bots aren't happy.
youenn fablet
Comment 7 2018-01-17 09:26:57 PST
(In reply to Chris Dumez from comment #6) > Comment on attachment 331205 [details] > Fixing WK1 > > Please check why win bots aren't happy. Sure, they are missing some flag definitions that I will add.
youenn fablet
Comment 8 2018-01-17 10:01:49 PST
Created attachment 331506 [details] Fixing Win
youenn fablet
Comment 9 2018-01-17 10:30:40 PST
Created attachment 331509 [details] Fixing Win
youenn fablet
Comment 10 2018-01-17 11:20:46 PST
Created attachment 331523 [details] Fixing Win
youenn fablet
Comment 11 2018-01-17 12:14:20 PST
Created attachment 331529 [details] Fixing Win
Radar WebKit Bug Importer
Comment 12 2018-01-17 12:42:56 PST
WebKit Commit Bot
Comment 13 2018-01-17 13:06:53 PST
Comment on attachment 331529 [details] Fixing Win Clearing flags on attachment: 331529 Committed r227079: <https://trac.webkit.org/changeset/227079>
WebKit Commit Bot
Comment 14 2018-01-17 13:06:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.