Bug 181592 - Put fetch Request.keepalive behind a runtime flag
Summary: Put fetch Request.keepalive behind a runtime flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-12 07:11 PST by youenn fablet
Modified: 2018-01-17 13:06 PST (History)
8 users (show)

See Also:

Attachments
Patch (7.51 KB, patch)
2018-01-12 07:15 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (8.70 KB, patch)
2018-01-12 07:20 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.19 MB, application/zip)
2018-01-12 08:23 PST, EWS Watchlist 		no flags Details
Fixing WK1 (18.10 KB, patch)
2018-01-12 08:59 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Fixing Win (18.27 KB, patch)
2018-01-17 10:01 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Fixing Win (19.69 KB, patch)
2018-01-17 10:30 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Fixing Win (18.62 KB, patch)
2018-01-17 11:20 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Fixing Win (19.26 KB, patch)
2018-01-17 12:14 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-01-12 07:11:27 PST 
Implementation is not complete yet
Comment 1 youenn fablet 2018-01-12 07:15:40 PST 
Created attachment 331200 [details]
Patch
Comment 2 youenn fablet 2018-01-12 07:20:35 PST 
Created attachment 331201 [details]
Patch
Comment 3 EWS Watchlist 2018-01-12 08:23:53 PST 
Comment on attachment 331201 [details]
Patch

Attachment 331201 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6050086

New failing tests:
imported/w3c/web-platform-tests/fetch/api/request/request-keepalive.html
Comment 4 EWS Watchlist 2018-01-12 08:23:55 PST 
Created attachment 331203 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 youenn fablet 2018-01-12 08:59:02 PST 
Created attachment 331205 [details]
Fixing WK1
Comment 6 Chris Dumez 2018-01-17 09:24:29 PST 
Comment on attachment 331205 [details]
Fixing WK1

Please check why win bots aren't happy.
Comment 7 youenn fablet 2018-01-17 09:26:57 PST 
(In reply to Chris Dumez from comment #6)
> Comment on attachment 331205 [details]
> Fixing WK1
> 
> Please check why win bots aren't happy.

Sure, they are missing some flag definitions that I will add.
Comment 8 youenn fablet 2018-01-17 10:01:49 PST 
Created attachment 331506 [details]
Fixing Win
Comment 9 youenn fablet 2018-01-17 10:30:40 PST 
Created attachment 331509 [details]
Fixing Win
Comment 10 youenn fablet 2018-01-17 11:20:46 PST 
Created attachment 331523 [details]
Fixing Win
Comment 11 youenn fablet 2018-01-17 12:14:20 PST 
Created attachment 331529 [details]
Fixing Win
Comment 12 Radar WebKit Bug Importer 2018-01-17 12:42:56 PST 
<rdar://problem/36593108>
Comment 13 WebKit Commit Bot 2018-01-17 13:06:53 PST 
Comment on attachment 331529 [details]
Fixing Win

Clearing flags on attachment: 331529

Committed r227079: <https://trac.webkit.org/changeset/227079>
Comment 14 WebKit Commit Bot 2018-01-17 13:06:54 PST 
All reviewed patches have been landed.  Closing bug.