Bug 181572

Summary: Disable Atomics when SharedArrayBuffer isn’t enabled
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, fpizlo, keith_miller, mark.lam, mjs, msaboff, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
ews-watchlist: commit-queue-
patch none

Saam Barati
Reported 2018-01-11 19:43:11 PST
...
Attachments
patch (3.85 KB, patch)
2018-01-16 12:09 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (4.55 KB, patch)
2018-01-16 12:16 PST, Saam Barati 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
patch (5.38 KB, patch)
2018-01-17 16:49 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2018-01-16 12:07:36 PST
<rdar://problem/36553206>
Saam Barati
Comment 2 2018-01-16 12:09:57 PST
Created attachment 331410 [details] patch This might make some tests fail. I'll let EWS tell me which tests need updating.
Saam Barati
Comment 3 2018-01-16 12:16:52 PST
Created attachment 331412 [details] patch
EWS Watchlist
Comment 4 2018-01-16 13:02:21 PST
Comment on attachment 331412 [details] patch Attachment 331412 [details] did not pass jsc-ews (mac): Output: http://webkit-queues.webkit.org/results/6096429 New failing tests: stress/isLockFree.js.ftl-eager stress/isLockFree.js.ftl-eager-no-cjit stress/isLockFree.js.no-cjit-collect-continuously stress/isLockFree.js.ftl-eager-no-cjit-b3o1 stress/isLockFree.js.default stress/isLockFree.js.ftl-no-cjit-validate-sampling-profiler stress/isLockFree.js.no-cjit-validate-phases stress/isLockFree.js.ftl-no-cjit-small-pool stress/isLockFree.js.dfg-eager stress/isLockFree.js.dfg-eager-no-cjit-validate stress/isLockFree.js.ftl-no-cjit-b3o1 stress/isLockFree.js.ftl-no-cjit-no-inline-validate stress/isLockFree.js.dfg-maximal-flush-validate-no-cjit stress/isLockFree.js.ftl-no-cjit-no-put-stack-validate stress/isLockFree.js.no-ftl stress/isLockFree.js.no-llint
Saam Barati
Comment 5 2018-01-17 16:49:01 PST
Created attachment 331560 [details] patch
Michael Saboff
Comment 6 2018-01-17 16:50:19 PST
Comment on attachment 331560 [details] patch r=me
WebKit Commit Bot
Comment 7 2018-01-17 17:58:29 PST
Comment on attachment 331560 [details] patch Clearing flags on attachment: 331560 Committed r227104: <https://trac.webkit.org/changeset/227104>
WebKit Commit Bot
Comment 8 2018-01-17 17:58:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.