Bug 181561

Summary: Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ews-watchlist, glenn, jbedard, joepeck, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=181332
Attachments:
Description Flags
CQ log
none
Patch
none
Patch
none
Patch none

Alexey Proskuryakov
Reported 2018-01-11 15:37:01 PST
Created attachment 331127 [details] CQ log Commit queue silently stopped working on https://bugs.webkit.org/attachment.cgi?id=330864&action=prettypatch
Attachments
CQ log (14.56 KB, text/plain)
2018-01-11 15:37 PST, Alexey Proskuryakov 		no flags
Details
Patch (1.50 KB, patch)
2018-01-11 15:56 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.13 KB, patch)
2018-01-11 16:04 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.17 KB, patch)
2018-01-11 16:19 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-01-11 15:37:33 PST
This bot failed in the same way on the next patch, so it's not just a one off.
Alexey Proskuryakov
Comment 2 2018-01-11 15:43:14 PST
I don't see this error in recent logs on webkit-cq-02 or webkit-cq-03. Only webkit-cq-01 so far.
Jonathan Bedard
Comment 3 2018-01-11 15:51:56 PST
We have a bunch of flakey layout tests, that's why commit queue is taking so long.
Radar WebKit Bug Importer
Comment 4 2018-01-11 15:53:21 PST
<rdar://problem/36452652>
Aakash Jain
Comment 5 2018-01-11 15:55:38 PST
Same as https://bugs.webkit.org/show_bug.cgi?id=181332
Aakash Jain
Comment 6 2018-01-11 15:55:48 PST
Might be a network issue while fetching the page from bugzilla, or the fetched page from bugzilla might not have the bz_result_count tag and BeautifulSoup fails to parse it properly.
Jonathan Bedard
Comment 7 2018-01-11 15:56:40 PST
Created attachment 331129 [details] Patch
Jonathan Bedard
Comment 8 2018-01-11 15:57:33 PST
(In reply to Jonathan Bedard from comment #7) > Created attachment 331129 [details] > Patch I'm concerned that this doesn't address the root cause, but it shouldn't be harmful.
Aakash Jain
Comment 9 2018-01-11 16:04:25 PST
Comment on attachment 331129 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331129&action=review > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:142 > + if result_count_text is None: Please add a log statement as well to print results_page and results_url, so that we can debug it next time similar issue happens.
Jonathan Bedard
Comment 10 2018-01-11 16:04:56 PST
Created attachment 331133 [details] Patch
Jonathan Bedard
Comment 11 2018-01-11 16:19:43 PST
Created attachment 331137 [details] Patch
Jonathan Bedard
Comment 12 2018-01-11 16:20:43 PST
(In reply to Jonathan Bedard from comment #11) > Created attachment 331137 [details] > Patch Committed in <https://trac.webkit.org/r226819>.
Aakash Jain
Comment 13 2018-01-11 16:22:55 PST
*** Bug 181332 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.