| Summary: | Add pop-up policy support in website policies | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zach Li <a.tion.surf> | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, a.tion.surf, cdumez, commit-queue, dbates, ews-watchlist, japhet, jberlin, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Zach Li
2018-01-11 11:02:04 PST
Created attachment 331111 [details]
Patch
Attachment 331111 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:830: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:837: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 2 in 18 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Build Bot from comment #2) > Attachment 331111 [details] did not pass style-queue: > > > ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:830: Place > brace on its own line for function definitions. [whitespace/braces] [4] > ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:837: Place > brace on its own line for function definitions. [whitespace/braces] [4] > Total errors found: 2 in 18 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. These errors are false positives, filed rdar://problem/36449728 to track the fix for it. Comment on attachment 331111 [details] Patch Clearing flags on attachment: 331111 Committed r226984: <https://trac.webkit.org/changeset/226984> All reviewed patches have been landed. Closing bug. |