Bug 181544

Summary: Add pop-up policy support in website policies
Product: WebKit Reporter: Zach Li <a.tion.surf>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, a.tion.surf, cdumez, commit-queue, dbates, ews-watchlist, japhet, jberlin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zach Li
Reported 2018-01-11 11:02:04 PST
Add pop-up policy support in website policies.
Attachments
Patch (35.13 KB, patch)
2018-01-11 13:38 PST, Zach Li 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zach Li
Comment 1 2018-01-11 13:38:11 PST
Created attachment 331111 [details] Patch
EWS Watchlist
Comment 2 2018-01-11 13:40:06 PST
Attachment 331111 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:830: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:837: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zach Li
Comment 3 2018-01-11 14:14:06 PST
(In reply to Build Bot from comment #2) > Attachment 331111 [details] did not pass style-queue: > > > ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:830: Place > brace on its own line for function definitions. [whitespace/braces] [4] > ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:837: Place > brace on its own line for function definitions. [whitespace/braces] [4] > Total errors found: 2 in 18 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. These errors are false positives, filed rdar://problem/36449728 to track the fix for it.
WebKit Commit Bot
Comment 4 2018-01-16 11:12:47 PST
Comment on attachment 331111 [details] Patch Clearing flags on attachment: 331111 Committed r226984: <https://trac.webkit.org/changeset/226984>
WebKit Commit Bot
Comment 5 2018-01-16 11:12:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-01-16 11:14:02 PST
<rdar://problem/36550845>
Note You need to log in before you can comment on or make changes to this bug.