Bug 181538

Summary:

webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, commit-queue, ews-watchlist, glenn, jlewis3, lforschler, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=180555

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Patch for landing	none

Jonathan Bedard

Reported 2018-01-11 09:19:11 PST

When disambiguating a device type, compare against the partially disambiguated type instead of the provided, and possibly ambiguous, device type.

Attachments
Patch (2.65 KB, patch) 2018-01-11 09:24 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.95 MB, application/zip) 2018-01-11 10:32 PST, EWS Watchlist	no flags	Details
Patch for landing (3.55 KB, patch) 2018-01-11 14:28 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-01-11 09:20:31 PST

<rdar://problem/36440580>

Jonathan Bedard

Comment 2 2018-01-11 09:24:10 PST

Created attachment 331059 [details] Patch

EWS Watchlist

Comment 3 2018-01-11 10:32:51 PST

Comment on attachment 331059 [details] Patch Attachment 331059 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6036337 New failing tests: webgl/1.0.2/conformance/uniforms/uniform-default-values.html

EWS Watchlist

Comment 4 2018-01-11 10:32:53 PST

Created attachment 331069 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Jonathan Bedard

Comment 5 2018-01-11 11:10:47 PST

(In reply to Build Bot from comment #4) > Created attachment 331069 [details] > Archive of layout-test-results from ews107 for mac-sierra-wk2 > > The attached test failures were seen while running run-webkit-tests on the > mac-wk2-ews. > Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6 Tree is red. This code is only run on iOS Simulator ports.

Aakash Jain

Comment 6 2018-01-11 13:52:54 PST

Comment on attachment 331059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331059&action=review > Tools/Scripts/webkitpy/xcode/new_simulated_device.py:201 > software_variant=device_type.software_variant) Add a comment here mentioning full_type is being copied from device_type. > Tools/Scripts/webkitpy/xcode/new_simulated_device.py:203 > + runtime = SimulatedDeviceManager.get_runtime_for_device_type(full_type) Rename full_type to more readable like full_device_type.

Jonathan Bedard

Comment 7 2018-01-11 14:28:43 PST

Created attachment 331120 [details] Patch for landing

WebKit Commit Bot

Comment 8 2018-01-11 19:31:32 PST

Comment on attachment 331120 [details] Patch for landing Clearing flags on attachment: 331120 Committed r226841: <https://trac.webkit.org/changeset/226841>

WebKit Commit Bot

Comment 9 2018-01-11 19:31:34 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.