When disambiguating a device type, compare against the partially disambiguated type instead of the provided, and possibly ambiguous, device type.
<rdar://problem/36440580>
Created attachment 331059 [details] Patch
Comment on attachment 331059 [details] Patch Attachment 331059 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6036337 New failing tests: webgl/1.0.2/conformance/uniforms/uniform-default-values.html
Created attachment 331069 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
(In reply to Build Bot from comment #4) > Created attachment 331069 [details] > Archive of layout-test-results from ews107 for mac-sierra-wk2 > > The attached test failures were seen while running run-webkit-tests on the > mac-wk2-ews. > Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6 Tree is red. This code is only run on iOS Simulator ports.
Comment on attachment 331059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331059&action=review > Tools/Scripts/webkitpy/xcode/new_simulated_device.py:201 > software_variant=device_type.software_variant) Add a comment here mentioning full_type is being copied from device_type. > Tools/Scripts/webkitpy/xcode/new_simulated_device.py:203 > + runtime = SimulatedDeviceManager.get_runtime_for_device_type(full_type) Rename full_type to more readable like full_device_type.
Created attachment 331120 [details] Patch for landing
Comment on attachment 331120 [details] Patch for landing Clearing flags on attachment: 331120 Committed r226841: <https://trac.webkit.org/changeset/226841>
All reviewed patches have been landed. Closing bug.