Bug 181530

Summary: Don't call RenderElement::setStyle when nothing changes
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
wip
none
wip
none
patch
zalan: review+
patch none

Antti Koivisto
Reported 2018-01-11 06:08:24 PST
This does quite a bit of work. Avoid unnecessary calls.
Attachments
wip (10.89 KB, patch)
2018-01-11 06:14 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
wip (10.89 KB, patch)
2018-01-11 06:27 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (12.82 KB, patch)
2018-01-11 07:29 PST, Antti Koivisto 		zalan: review+
DetailsFormatted DiffDiff
patch (12.94 KB, patch)
2018-01-11 12:14 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-01-11 06:14:01 PST
Created attachment 331047 [details] wip
Antti Koivisto
Comment 2 2018-01-11 06:27:38 PST
Created attachment 331049 [details] wip
Antti Koivisto
Comment 3 2018-01-11 07:29:45 PST
Created attachment 331051 [details] patch
Antti Koivisto
Comment 4 2018-01-11 12:14:53 PST
Created attachment 331091 [details] patch
WebKit Commit Bot
Comment 5 2018-01-11 14:43:34 PST
Comment on attachment 331091 [details] patch Clearing flags on attachment: 331091 Committed r226809: <https://trac.webkit.org/changeset/226809>
WebKit Commit Bot
Comment 6 2018-01-11 14:43:36 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-01-11 14:44:17 PST
<rdar://problem/36450650>
Note You need to log in before you can comment on or make changes to this bug.