Bug 181518

Summary: REGRESSION(r218975): Web Inspector: Add back NavigationSidebarPanel initialization parameter used by SearchSidebarPanel (top overflow shadow)
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Before - Sidebar no top border
none
[IMAGE] After - Sidebar has a top border when scrolled
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2018-01-10 20:34:55 PST
Remove unused initialization parameter in SearchSidebarPanel
Attachments
[IMAGE] Before - Sidebar no top border (349.67 KB, image/png)
2018-01-10 20:54 PST, Joseph Pecoraro 		no flags
Details
[IMAGE] After - Sidebar has a top border when scrolled (299.10 KB, image/png)
2018-01-10 20:54 PST, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix (3.14 KB, patch)
2018-01-10 20:55 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2018-01-10 20:48:26 PST
Actually this parameter is still used and should be added back.
Radar WebKit Bug Importer
Comment 2 2018-01-10 20:53:22 PST
<rdar://problem/36427197>
Joseph Pecoraro
Comment 3 2018-01-10 20:54:00 PST
Created attachment 331021 [details] [IMAGE] Before - Sidebar no top border
Joseph Pecoraro
Comment 4 2018-01-10 20:54:12 PST
Created attachment 331022 [details] [IMAGE] After - Sidebar has a top border when scrolled
Joseph Pecoraro
Comment 5 2018-01-10 20:55:47 PST
Created attachment 331023 [details] [PATCH] Proposed Fix
Matt Baker
Comment 6 2018-01-10 21:22:55 PST
Comment on attachment 331023 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 7 2018-01-10 23:07:56 PST
Comment on attachment 331023 [details] [PATCH] Proposed Fix Clearing flags on attachment: 331023 Committed r226765: <https://trac.webkit.org/changeset/226765>
WebKit Commit Bot
Comment 8 2018-01-10 23:07:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.