Bug 181484

Summary: REGRESSION (r226715): don't re-check number of simulators in child processes
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, ews-watchlist, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=180555
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2018-01-10 08:53:00 PST
Checking the number of simulators to be run against the maximum number of simulators a machine can support only makes sense before those simulators have been initialized.
Attachments
Patch (1.70 KB, patch)
2018-01-10 08:58 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-10 08:54:05 PST
<rdar://problem/36407151>
Jonathan Bedard
Comment 2 2018-01-10 08:58:27 PST
Created attachment 330916 [details] Patch
Aakash Jain
Comment 3 2018-01-10 10:56:33 PST
Comment on attachment 330916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330916&action=review > Tools/Scripts/webkitpy/port/ios_simulator.py:53 > + if not SimulatedDeviceManager.INITIALIZED_DEVICES and self.get_option('child_processes', self.default_child_processes()) > SimulatedDeviceManager.max_supported_simulators(self.host): Just for future reference, max_supported_simulators seems like a misleading name, it should be something like current_num_supported_simulators. We wouldn't had this issue if max_supported_simulators always return the same value (maximum number of simulators supported by the machine).
WebKit Commit Bot
Comment 4 2018-01-10 11:58:29 PST
Comment on attachment 330916 [details] Patch Clearing flags on attachment: 330916 Committed r226726: <https://trac.webkit.org/changeset/226726>
WebKit Commit Bot
Comment 5 2018-01-10 11:58:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.