Bug 181474

Summary: WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, clopez, cturner, ews-watchlist, glenn, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch clopez: review+

Carlos Garcia Campos
Reported 2018-01-10 04:26:58 PST
We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest name as the name. For example: find_element.py::test_xhtml_namespace[xpath-//*[name()='a']] -> *[name()='a']]
Attachments
Patch (2.10 KB, patch)
2018-01-10 04:29 PST, Carlos Garcia Campos 		clopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2018-01-10 04:29:05 PST
Created attachment 330892 [details] Patch
Charlie Turner
Comment 2 2018-01-10 04:35:02 PST
Comment on attachment 330892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330892&action=review > Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:82 > + def _subtest_name(self, subtest): Looks like this could be a free function, self isn't referenced in the body.
Carlos Alberto Lopez Perez
Comment 3 2018-01-10 06:36:29 PST
Comment on attachment 330892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330892&action=review >> Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:82 >> + def _subtest_name(self, subtest): > > Looks like this could be a free function, self isn't referenced in the body. I think its ok to have it as part of the object if it is related to it.
Carlos Garcia Campos
Comment 4 2018-01-10 06:45:06 PST
Committed r226711: <https://trac.webkit.org/changeset/226711>
Radar WebKit Bug Importer
Comment 5 2018-01-10 06:46:29 PST
<rdar://problem/36405305>
Note You need to log in before you can comment on or make changes to this bug.