Bug 181465

Summary: Web Inspector: Layers sidebar shows popover on selection even when collapsed
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: Web InspectorAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 174176    
Attachments:
Description Flags
Problem
none
Patch none

Ross Kirsling
Reported 2018-01-09 17:48:00 PST
Created attachment 330867 [details] Problem Repro: 1. Go to Layers tab. 2. Manually close details sidebar. 3. Click a layer in the visualization. => Popover appears while sidebar remains hidden.
Attachments
Problem (329.93 KB, image/png)
2018-01-09 17:48 PST, Ross Kirsling 		no flags
Details
Patch (1.93 KB, patch)
2018-01-09 17:50 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2018-01-09 17:50:01 PST
Created attachment 330868 [details] Patch
Matt Baker
Comment 3 2018-01-09 18:39:17 PST
Comment on attachment 330868 [details] Patch r=me. I think this UI would benefit from dropped the popover altogether. Maybe a navigation sidebar would be better suited to this, with a panel below the layer tree/grid that shows the compositing info, etc, for the selected item. Just a thought.
WebKit Commit Bot
Comment 4 2018-01-09 18:43:40 PST
Comment on attachment 330868 [details] Patch Clearing flags on attachment: 330868 Committed r226671: <https://trac.webkit.org/changeset/226671>
WebKit Commit Bot
Comment 5 2018-01-09 18:43:42 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-01-09 18:44:17 PST
<rdar://problem/36395057>
Ross Kirsling
Comment 7 2018-01-09 19:00:41 PST
> Comment on attachment 330868 [details] > Patch > > r=me. I think this UI would benefit from dropped the popover altogether. > Maybe a navigation sidebar would be better suited to this, with a panel > below the layer tree/grid that shows the compositing info, etc, for the > selected item. Just a thought. I would love to do this; the reason I didn't/haven't is because I don't know what becomes of the other table columns in that case. "Sorting by memory consumption" seems like a crucial piece of this tab's workflow. :(
Note You need to log in before you can comment on or make changes to this bug.