Bug 181446

Summary: Make service workers behave correctly with regards to Page Cache
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Service WorkersAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2018-01-09 12:50:47 PST
Make service workers behave correctly with regards to Page Cache.
Attachments
Patch (16.29 KB, patch)
2018-01-09 12:53 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-01-09 12:51:05 PST
<rdar://problem/36164291>
Chris Dumez
Comment 2 2018-01-09 12:53:34 PST
Created attachment 330843 [details] Patch
youenn fablet
Comment 3 2018-01-09 16:15:02 PST
Comment on attachment 330843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330843&action=review > Source/WebCore/dom/Document.cpp:4919 > + ASSERT_WITH_MESSAGE(!activeServiceWorker(), "Documents with an active service worker should not go into PageCache in the first place"); Maybe the message should be made specific here?
Chris Dumez
Comment 4 2018-01-09 18:46:11 PST
(In reply to youenn fablet from comment #3) > Comment on attachment 330843 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=330843&action=review > > > Source/WebCore/dom/Document.cpp:4919 > > + ASSERT_WITH_MESSAGE(!activeServiceWorker(), "Documents with an active service worker should not go into PageCache in the first place"); > > Maybe the message should be made specific here? What do you mean? What’s not specific enough?
WebKit Commit Bot
Comment 5 2018-01-09 20:08:39 PST
Comment on attachment 330843 [details] Patch Clearing flags on attachment: 330843 Committed r226677: <https://trac.webkit.org/changeset/226677>
WebKit Commit Bot
Comment 6 2018-01-09 20:08:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.