Summary: | [GTK] Problem with Washington Post images | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | bugzilla-ok | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Major | CC: | bugs-noreply, cgarcia, clopez, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
bugzilla-ok
2018-01-08 17:30:59 PST
This is because Washington Post is using the user agent to decide the image formats it serves. In the case of chromium the images are served as webp, for firefox jpeg is used and in our case it's assuming we are safari and it's providing jp2 images that we don't support. So, we would need a user agent quirk to pretend to be firefox or chromium (I guess better chromium in this case) or add an image decoder for jpeg 2000. Created attachment 332869 [details]
Patch
This is the easiest solution in the short-medium term.
Mmmm, good catch. And I'm checking that people is actually recommending do this to webmasters: parse the user-agent string to guess if JP2 support is available "because Safari doesn't expose support for it on the accept-header" https://blog.elijaa.org/2016/01/29/detect-webp-jpeg2000-jpegxr-image-format-support-in-php/ So we may be bitten by this on more sites than on Washington post :( (In reply to Carlos Alberto Lopez Perez from comment #3) > Mmmm, good catch. > > And I'm checking that people is actually recommending do this to webmasters: > parse the user-agent string to guess if JP2 support is available "because > Safari doesn't expose support for it on the accept-header" > https://blog.elijaa.org/2016/01/29/detect-webp-jpeg2000-jpegxr-image-format- > support-in-php/ > > So we may be bitten by this on more sites than on Washington post :( That's why I think adding support for jpeg2000 could be the long term solution. Committed r227965: <https://trac.webkit.org/changeset/227965> |