Bug 181419

Summary: Pass around Vector<Ref<WebContextMenuItem>> instead of WKArrayRef or Vector<WebContextMenuItemData>
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2018-01-08 17:27:06 PST
Pass around Vector<Ref<WebContextMenuItem>> instead of WKArrayRef or Vector<WebContextMenuItemData>
Attachments
Patch (7.17 KB, patch)
2018-01-08 17:28 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (8.56 KB, patch)
2018-01-08 17:35 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (9.14 KB, patch)
2018-01-08 17:40 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-01-08 17:28:20 PST
Created attachment 330763 [details] Patch
Alex Christensen
Comment 2 2018-01-08 17:35:18 PST
Created attachment 330766 [details] Patch
Alex Christensen
Comment 3 2018-01-08 17:40:04 PST
Created attachment 330767 [details] Patch
Alex Christensen
Comment 4 2018-01-08 17:54:06 PST
http://trac.webkit.org/r226602
Radar WebKit Bug Importer
Comment 5 2018-01-08 17:58:42 PST
<rdar://problem/36366090>
Ryosuke Niwa
Comment 6 2018-01-08 19:08:59 PST
This patch appears to have broken iOS builds: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator11.0.sdk/System/Library/Frameworks/System.framework/PrivateHeaders -include /Volumes/Data/EWS/WebKit/WebKitBuild/PrecompiledHeaders/WebKit2Prefix-drveltbyitydmohjorffrkcgteab/WebKit2Prefix.h -MMD -MT dependencies -MF /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release-iphonesimulator/WebKit.build/Objects-normal/x86_64/WKContextMenuListener.d --serialize-diagnostics /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release-iphonesimulator/WebKit.build/Objects-normal/x86_64/WKContextMenuListener.dia -c /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release-iphonesimulator/WebKit.build/Objects-normal/x86_64/WKContextMenuListener.o /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp:63:18: error: use of undeclared identifier 'items' UNUSED_PARAM(items); ^ Fix attempted in https://trac.webkit.org/changeset/226608
Note You need to log in before you can comment on or make changes to this bug.