Bug 181414

Summary: Add additional WEBCORE_EXPORTs
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WebCore Misc.Assignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, commit-queue, darin, ews-watchlist, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2018-01-08 16:31:56 PST
Add additional exports when compiling webcore as a shared library.
Attachments
Patch (29.80 KB, patch)
2018-01-08 16:35 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-01-08 16:35:41 PST
Created attachment 330753 [details] Patch These missing WEBCORE_EXPORTs were found when compiling out WebCore as a shared library on PlayStation which uses the __declspec that Windows uses for exports.
EWS Watchlist
Comment 2 2018-01-08 16:37:50 PST
Attachment 330753 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/AuthenticationChallengeBase.h:40: The parameter name "protectionSpace" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/AuthenticationChallengeBase.h:40: The parameter name "response" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/AuthenticationChallengeBase.h:40: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/replay/UserInputBridge.h:71: The parameter name "source" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2018-01-09 13:17:24 PST
Comment on attachment 330753 [details] Patch Clearing flags on attachment: 330753 Committed r226657: <https://trac.webkit.org/changeset/226657>
WebKit Commit Bot
Comment 4 2018-01-09 13:17:26 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-01-09 13:18:26 PST
<rdar://problem/36383861>
Note You need to log in before you can comment on or make changes to this bug.