Bug 181414 - Add additional WEBCORE_EXPORTs
Summary: Add additional WEBCORE_EXPORTs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-08 16:31 PST by Don Olmstead
Modified: 2018-01-09 13:18 PST (History)
7 users (show)

See Also:

Attachments
Patch (29.80 KB, patch)
2018-01-08 16:35 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-01-08 16:31:56 PST 
Add additional exports when compiling webcore as a shared library.
Comment 1 Don Olmstead 2018-01-08 16:35:41 PST 
Created attachment 330753 [details]
Patch

These missing WEBCORE_EXPORTs were found when compiling out WebCore as a shared library on PlayStation which uses the __declspec that Windows uses for exports.
Comment 2 EWS Watchlist 2018-01-08 16:37:50 PST 
Attachment 330753 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/AuthenticationChallengeBase.h:40:  The parameter name "protectionSpace" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/AuthenticationChallengeBase.h:40:  The parameter name "response" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/AuthenticationChallengeBase.h:40:  The parameter name "error" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/replay/UserInputBridge.h:71:  The parameter name "source" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2018-01-09 13:17:24 PST 
Comment on attachment 330753 [details]
Patch

Clearing flags on attachment: 330753

Committed r226657: <https://trac.webkit.org/changeset/226657>
Comment 4 WebKit Commit Bot 2018-01-09 13:17:26 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-01-09 13:18:26 PST 
<rdar://problem/36383861>