Bug 181413

Summary:

Make ObjC SPI equivalent to WKPageNavigationClient.decidePolicyForPluginLoad

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jeffm, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Alex Christensen 2018-01-08 16:17:36 PST

Make ObjC SPI equivalent to WKPageNavigationClient.decidePolicyForPluginLoad

Comment 1 Alex Christensen 2018-01-08 16:20:36 PST

Created attachment 330751 [details]
Patch

Comment 2 Wenson Hsieh 2018-01-08 19:15:56 PST

Comment on attachment 330751 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330751&action=review

> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:316
> +static WebKit::PluginModuleLoadPolicy toPluginModuleLoadPolicy(_WKPluginModuleLoadPolicy policy)

Nit - I think https://webkit.org/code-style-guidelines/#names-verb recommends against prefixing with "to".

Comment 3 Alex Christensen 2018-01-08 19:24:30 PST

Created attachment 330783 [details]
Patch

Comment 4 Alex Christensen 2018-01-08 19:26:30 PST

http://trac.webkit.org/r226609

Comment 5 Radar WebKit Bug Importer 2018-01-08 19:29:50 PST

<rdar://problem/36367364>

Comment 6 Jeff Miller 2018-08-20 16:55:32 PDT

*** Bug 181073 has been marked as a duplicate of this bug. ***