Bug 181405

Summary:

[RenderTreeBuilder] Move SVG addChild logic to RenderTreeBuilder

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2018-01-08 14:41:49 PST

ssia.

Comment 1 Radar WebKit Bug Importer 2018-01-08 14:42:09 PST

<rdar://problem/36360476>

Comment 2 zalan 2018-01-08 14:44:35 PST

Created attachment 330738 [details]
Patch

Comment 3 Antti Koivisto 2018-01-08 14:47:35 PST

Comment on attachment 330738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330738&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.h:89
> +    SVG& SVGBuilder() { return *m_SVGBuilder; }

I think it is svgBuilder() and m_svgBuilder by our naming conventions.

Comment 4 zalan 2018-01-08 14:52:46 PST

Created attachment 330740 [details]
Patch

Comment 5 WebKit Commit Bot 2018-01-08 15:14:15 PST

Comment on attachment 330740 [details]
Patch

Clearing flags on attachment: 330740

Committed r226568: <https://trac.webkit.org/changeset/226568>

Comment 6 WebKit Commit Bot 2018-01-08 15:14:16 PST

All reviewed patches have been landed.  Closing bug.