Bug 181405 - [RenderTreeBuilder] Move SVG addChild logic to RenderTreeBuilder
Summary: [RenderTreeBuilder] Move SVG addChild logic to RenderTreeBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-08 14:41 PST by zalan
Modified: 2018-01-08 15:14 PST (History)
6 users (show)

See Also:


Attachments
Patch (19.14 KB, patch)
2018-01-08 14:44 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (19.14 KB, patch)
2018-01-08 14:52 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-01-08 14:41:49 PST
ssia.
Comment 1 Radar WebKit Bug Importer 2018-01-08 14:42:09 PST
<rdar://problem/36360476>
Comment 2 zalan 2018-01-08 14:44:35 PST
Created attachment 330738 [details]
Patch
Comment 3 Antti Koivisto 2018-01-08 14:47:35 PST
Comment on attachment 330738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330738&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.h:89
> +    SVG& SVGBuilder() { return *m_SVGBuilder; }

I think it is svgBuilder() and m_svgBuilder by our naming conventions.
Comment 4 zalan 2018-01-08 14:52:46 PST
Created attachment 330740 [details]
Patch
Comment 5 WebKit Commit Bot 2018-01-08 15:14:15 PST
Comment on attachment 330740 [details]
Patch

Clearing flags on attachment: 330740

Committed r226568: <https://trac.webkit.org/changeset/226568>
Comment 6 WebKit Commit Bot 2018-01-08 15:14:16 PST
All reviewed patches have been landed.  Closing bug.