Bug 181387

Summary: [FreeType] Use FastMalloc for FreeType
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mcatanzaro, mmaxfield, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch mcatanzaro: review+

Yusuke Suzuki
Reported 2018-01-08 05:15:03 PST
[FreeType] Use FastMalloc for FreeType
Attachments
Patch (2.47 KB, patch)
2018-01-08 05:16 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (2.47 KB, patch)
2018-01-08 05:18 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (2.61 KB, patch)
2018-01-08 06:04 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (2.77 KB, patch)
2018-01-09 07:44 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (2.77 KB, patch)
2018-01-09 07:56 PST, Yusuke Suzuki 		mcatanzaro: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-01-08 05:16:01 PST
Created attachment 330689 [details] Patch
EWS Watchlist
Comment 2 2018-01-08 05:16:54 PST
Attachment 330689 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 3 2018-01-08 05:18:56 PST
Created attachment 330691 [details] Patch
Yusuke Suzuki
Comment 4 2018-01-08 06:04:03 PST
Created attachment 330697 [details] Patch
Yusuke Suzuki
Comment 5 2018-01-09 07:44:10 PST
Created attachment 330823 [details] Patch
Yusuke Suzuki
Comment 6 2018-01-09 07:56:20 PST
Created attachment 330824 [details] Patch
Michael Catanzaro
Comment 7 2018-01-09 08:16:38 PST
Comment on attachment 330824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330824&action=review > Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:81 > + UNUSED_PARAM(currentSize); Better style would be to just not name the parameter IMO. You already left links to the documentation, so people can look it up if they want to know what it is.
Yusuke Suzuki
Comment 8 2018-01-09 08:19:45 PST
Comment on attachment 330824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330824&action=review Thanks! >> Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:81 >> + UNUSED_PARAM(currentSize); > > Better style would be to just not name the parameter IMO. You already left links to the documentation, so people can look it up if they want to know what it is. OK, dropped this name.
Yusuke Suzuki
Comment 9 2018-01-09 08:24:00 PST
Committed r226635: <https://trac.webkit.org/changeset/226635>
Radar WebKit Bug Importer
Comment 10 2018-01-09 08:25:06 PST
<rdar://problem/36376027>
Note You need to log in before you can comment on or make changes to this bug.