Bug 181385

Summary:

Add CSP support to service workers

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Service Workers

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, cdumez, commit-queue, dbates, ews-watchlist, ggaren, mkwst, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

181422

Bug Blocks:

181434

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

youenn fablet

Reported 2018-01-08 04:08:56 PST

Add CSP support to service workers

Attachments
Patch (39.59 KB, patch) 2018-01-08 04:20 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (39.53 KB, patch) 2018-01-08 12:45 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (34.14 KB, patch) 2018-01-09 05:23 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-01-08 04:20:42 PST

Created attachment 330681 [details] Patch

EWS Watchlist

Comment 2 2018-01-08 04:22:06 PST

Attachment 330681 [details] did not pass style-queue: ERROR: Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:74: Missing spaces around : [whitespace/init] [4] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 3 2018-01-08 04:49:13 PST

rdar://problem/36164094

youenn fablet

Comment 4 2018-01-08 09:34:35 PST

Comment on attachment 330681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330681&action=review > Source/WebCore/workers/WorkerScriptLoader.h:29 > +#include "ContentSecurityPolicyResponseHeaders.h" Include might not be needed in fact, will check this in a future iteration.

Chris Dumez

Comment 5 2018-01-08 10:42:45 PST

Comment on attachment 330681 [details] Patch Darn, I had the same patch locally that I did before the break.

youenn fablet

Comment 6 2018-01-08 10:54:56 PST

Thanks for the review. (In reply to Chris Dumez from comment #5) > Comment on attachment 330681 [details] > Patch > > Darn, I had the same patch locally that I did before the break. We 'll call it the double-bullet-proof patch!

youenn fablet

Comment 7 2018-01-08 10:55:13 PST

Comment on attachment 330681 [details] Patch Not sure it will land without rebasing, but let's try

WebKit Commit Bot

Comment 8 2018-01-08 10:56:05 PST

Comment on attachment 330681 [details] Patch Rejecting attachment 330681 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 330681, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ervice-workers/service-worker/service-worker-csp-connect.https-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-default.https-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-script.https-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/5975033

youenn fablet

Comment 9 2018-01-08 12:45:38 PST

Created attachment 330725 [details] Patch for landing

EWS Watchlist

Comment 10 2018-01-08 12:47:32 PST

Attachment 330725 [details] did not pass style-queue: ERROR: Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:74: Missing spaces around : [whitespace/init] [4] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 11 2018-01-08 13:19:28 PST

Comment on attachment 330725 [details] Patch for landing Clearing flags on attachment: 330725 Committed r226532: <https://trac.webkit.org/changeset/226532>

WebKit Commit Bot

Comment 12 2018-01-08 13:19:30 PST

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 13 2018-01-08 18:05:30 PST

Re-opened since this is blocked by bug 181422

youenn fablet

Comment 14 2018-01-09 05:23:51 PST

Created attachment 330814 [details] Patch for landing

youenn fablet

Comment 15 2018-01-09 05:24:22 PST

(In reply to youenn fablet from comment #14) > Created attachment 330814 [details] > Patch for landing Relanding without modifying the SQL database, hence no CSP data persistency support.

EWS Watchlist

Comment 16 2018-01-09 05:25:22 PST

Attachment 330814 [details] did not pass style-queue: ERROR: Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:74: Missing spaces around : [whitespace/init] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 17 2018-01-09 05:57:28 PST

Comment on attachment 330814 [details] Patch for landing Clearing flags on attachment: 330814 Committed r226628: <https://trac.webkit.org/changeset/226628>

WebKit Commit Bot

Comment 18 2018-01-09 05:57:30 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.