| Summary: | [Cairo] Contain shadow blur requirement state in a separate object | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, ews-watchlist, mmaxfield, Ms2ger, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Zan Dobersek
2018-01-08 03:16:27 PST
Created attachment 330675 [details]
Patch
Comment on attachment 330675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330675&action=review > Source/WebCore/ChangeLog:12 > + transform ingorance are stored there. Additionally, the required() "ingorance" Comment on attachment 330675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330675&action=review > Source/WebCore/platform/graphics/cairo/CairoOperations.h:81 > + ShadowBlurUsage() = default; Why is this needed? > Source/WebCore/platform/graphics/cairo/CairoOperations.h:88 > + float shadowBlur; > + bool shadowsIgnoreTransforms; These are uninitialized when the default ctor is used. Created attachment 330700 [details]
Patch for landing
Addresses all the review comments
Comment on attachment 330700 [details] Patch for landing Clearing flags on attachment: 330700 Committed r226509: <https://trac.webkit.org/changeset/226509> All reviewed patches have been landed. Closing bug. |