Bug 181380

Summary: [Cairo] Contain shadow blur requirement state in a separate object
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, ews-watchlist, mmaxfield, Ms2ger, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2018-01-08 03:16:27 PST
[Cairo] Contain shadow blur requirement state in a separate object
Attachments
Patch (12.21 KB, patch)
2018-01-08 03:32 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.21 KB, patch)
2018-01-08 06:35 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-01-08 03:32:31 PST
Created attachment 330675 [details] Patch
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 2 2018-01-08 04:05:14 PST
Comment on attachment 330675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330675&action=review > Source/WebCore/ChangeLog:12 > + transform ingorance are stored there. Additionally, the required() "ingorance"
Carlos Garcia Campos
Comment 3 2018-01-08 05:04:07 PST
Comment on attachment 330675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330675&action=review > Source/WebCore/platform/graphics/cairo/CairoOperations.h:81 > + ShadowBlurUsage() = default; Why is this needed? > Source/WebCore/platform/graphics/cairo/CairoOperations.h:88 > + float shadowBlur; > + bool shadowsIgnoreTransforms; These are uninitialized when the default ctor is used.
Zan Dobersek
Comment 4 2018-01-08 06:35:37 PST
Created attachment 330700 [details] Patch for landing Addresses all the review comments
Zan Dobersek
Comment 5 2018-01-08 06:38:26 PST
Comment on attachment 330700 [details] Patch for landing Clearing flags on attachment: 330700 Committed r226509: <https://trac.webkit.org/changeset/226509>
Zan Dobersek
Comment 6 2018-01-08 06:38:30 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-01-08 06:39:17 PST
<rdar://problem/36348527>
Note You need to log in before you can comment on or make changes to this bug.