Bug 181363

Summary: Use WeakPtr for RenderTreePosition::m_nextSibling
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2018-01-06 04:05:02 PST
For safety.
Attachments
patch (2.57 KB, patch)
2018-01-06 04:09 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-01-06 04:09:38 PST
Created attachment 330637 [details] patch
alan
Comment 2 2018-01-06 08:14:17 PST
Comment on attachment 330637 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=330637&action=review > Source/WebCore/rendering/updating/RenderTreePosition.h:60 > + WeakPtr<RenderObject> m_nextSibling { nullptr }; { nullptr } is not really needed here.
WebKit Commit Bot
Comment 3 2018-01-06 13:01:23 PST
Comment on attachment 330637 [details] patch Clearing flags on attachment: 330637 Committed r226488: <https://trac.webkit.org/changeset/226488>
WebKit Commit Bot
Comment 4 2018-01-06 13:01:24 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-01-06 13:02:52 PST
<rdar://problem/36336120>
Note You need to log in before you can comment on or make changes to this bug.