Bug 181347

Summary: Clean up Marquee-related enums
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Simon Fraser (smfr) 2018-01-05 14:35:17 PST 
Clean up Marquee-related enums
Comment 1 Simon Fraser (smfr) 2018-01-05 14:38:51 PST 
Created attachment 330586 [details]
Patch
Comment 2 Anders Carlsson 2018-01-06 09:58:30 PST 
Fails on Windows:

c:\cygwin\home\buildbot\webkit\source\webcore\rendering\rendermarquee.cpp(95): error C2220: warning treated as error - no 'object' file generated [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
c:\cygwin\home\buildbot\webkit\source\webcore\rendering\rendermarquee.cpp(95): warning C4715: 'WebCore::reverseDirection': not all control paths return a value [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
Comment 3 Simon Fraser (smfr) 2018-01-16 08:51:31 PST 
https://trac.webkit.org/changeset/226666/webkit
Comment 4 Radar WebKit Bug Importer 2018-01-16 08:52:37 PST 
<rdar://problem/36545519>