Bug 181344

Summary: Simplify platform checks in Graphics Context
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dino, ews-watchlist, graouts, kondapallykalyan, noam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Don Olmstead
Reported 2018-01-05 14:11:15 PST
Currently there are a lot of PLATFORM checks around GraphicsContext that could be simplified and make it easier for out of trunk ports to build.
Attachments
Patch (4.17 KB, patch)
2018-01-05 14:58 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (4.22 KB, patch)
2018-01-08 11:56 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-01-05 14:58:30 PST
Created attachment 330589 [details] Patch
EWS Watchlist
Comment 2 2018-01-05 14:59:24 PST
Attachment 330589 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 3 2018-01-08 11:56:53 PST
Created attachment 330718 [details] Patch
Don Olmstead
Comment 4 2018-01-08 11:58:54 PST
Comment on attachment 330718 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330718&action=review Think this is ready for review. Just wondering if any of the platform checks can be simplified further. > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:400 > +#if !PLATFORM(IOS) && !USE(OPENGL_ES_2) I'm not sure if this is correct for iOS or if it should just be if !USE(OPENGL_ES_2).
WebKit Commit Bot
Comment 5 2018-01-08 15:27:56 PST
Comment on attachment 330718 [details] Patch Clearing flags on attachment: 330718 Committed r226581: <https://trac.webkit.org/changeset/226581>
WebKit Commit Bot
Comment 6 2018-01-08 15:27:57 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-01-08 15:28:17 PST
<rdar://problem/36361902>
Note You need to log in before you can comment on or make changes to this bug.