Bug 181324

Summary: REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by unconditionally copied header files of DerivedSources
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: New BugsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, commit-queue, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2018-01-05 02:36:17 PST
Bug 180921 changes to use cmake -E copy to copy header files of DerivedSources. This command copies files unconditionally, then introduced unnecessary recompilations. cmake -E copy_if_different should be used.
Attachments
Patch (1.84 KB, patch)
2018-01-05 02:40 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-01-05 02:40:04 PST
Created attachment 330543 [details] Patch
WebKit Commit Bot
Comment 2 2018-01-05 03:11:47 PST
Comment on attachment 330543 [details] Patch Clearing flags on attachment: 330543 Committed r226442: <https://trac.webkit.org/changeset/226442>
WebKit Commit Bot
Comment 3 2018-01-05 03:11:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-01-05 03:12:38 PST
<rdar://problem/36316638>
Note You need to log in before you can comment on or make changes to this bug.