Bug 181319 – [RenderTreeBuilder] Move RenderBlock addChild logic to RenderTreeBuilder

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

ssia.

[Radar WebKit Bug Importer]

<rdar://problem/36313464>

[alan]

Created attachment 330531 [details]
Patch

[EWS Watchlist]

Attachment 330531 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp:126:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[alan]

Created attachment 330532 [details]
Patch

[EWS Watchlist]

Attachment 330532 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp:126:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Comment on attachment 330532 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330532&action=review

> Source/WebCore/rendering/RenderBlock.cpp:2980
> -    makeChildrenNonInline();
> +    RenderTreeBuilder::makeChildrenNonInline(*this);

For consistency and future I think these should be non-static members of RenderTreeBuilder. You can use RenderTreeBuilder::current() to get the instance for now.

> Source/WebCore/rendering/updating/RenderTreeBuilder.h:53
> +    static void makeChildrenNonInline(RenderBlock& parent, RenderObject* insertionPoint = nullptr);
> +    static RenderObject* splitAnonymousBoxesAroundChild(RenderBox& parent, RenderObject* beforeChild);

For consistency and future I think these should be non-static members of RenderTreeBuilder. You can use RenderTreeBuilder::current() to get the instance without having to pass it around.

[alan]

Created attachment 330551 [details]
Patch

[EWS Watchlist]

Attachment 330551 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp:126:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[alan]

Created attachment 330706 [details]
Patch

[EWS Watchlist]

Attachment 330706 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp:126:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 330706 [details]
Patch

Clearing flags on attachment: 330706

Committed r226516: <https://trac.webkit.org/changeset/226516>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.