Bug 181299

Summary: Do value profiling in to_this
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2018-01-04 11:58:15 PST
When looping over node, for ToThis, we should assign node to ToThis->child1().node(). Also, we should extend the heuristic for https://bugs.webkit.org/show_bug.cgi?id=181296 to also account for GetLocal.
Attachments
patch (10.55 KB, patch)
2018-01-04 18:24 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2018-01-04 16:52:36 PST
(In reply to Saam Barati from comment #0) > When looping over node, for ToThis, we should assign node to > ToThis->child1().node(). > Also, we should extend the heuristic for > https://bugs.webkit.org/show_bug.cgi?id=181296 to also account for GetLocal. We should not do this. But we should have ToThis do value profiling. Right now, we do this stupid thing (for strict mode): ToThis(@something prediction SpecObjectOther) Will say the ToThis produces SpecObjectOther. But really, who knows what this produces. SpecObjectOther means the thing could have a custom toThis that does arbitrary things.
Saam Barati
Comment 2 2018-01-04 18:24:23 PST
Created attachment 330505 [details] patch
WebKit Commit Bot
Comment 3 2018-01-04 21:12:55 PST
Comment on attachment 330505 [details] patch Clearing flags on attachment: 330505 Committed r226436: <https://trac.webkit.org/changeset/226436>
WebKit Commit Bot
Comment 4 2018-01-04 21:12:57 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-01-04 21:13:18 PST
<rdar://problem/36313127>
Note You need to log in before you can comment on or make changes to this bug.