Bug 181296

Summary: Add a new pattern matching rule to Graph::methodOfGettingAValueProfileFor for SetLocal(@nodeWithHeapPrediction)
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
fpizlo: review+
patch for landing
none
patch for landing
none
patch for landing none

Saam Barati
Reported 2018-01-04 10:47:35 PST
Often they'll be from the same origin, so they don't fall into the normal loop that checks nodes from different origins. Speedometer has a lot of: ``` a:GetByVal(..., originX) SetLocal(Cell:@a, locY, originX) ``` Where Cell:@a fails a lot. In such a case, it makes sense to update the value profile for the GetByVal.
Attachments
patch (3.27 KB, patch)
2018-01-04 11:41 PST, Saam Barati 		fpizlo: review+
DetailsFormatted DiffDiff
patch for landing (3.12 KB, patch)
2018-01-04 12:33 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing (2.94 KB, patch)
2018-01-04 12:34 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing (2.81 KB, patch)
2018-01-04 12:35 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2018-01-04 11:41:14 PST
Created attachment 330476 [details] patch
Saam Barati
Comment 2 2018-01-04 12:33:34 PST
Created attachment 330479 [details] patch for landing Made a slight change from the patch pizlo reviewed. Will wait for his thumbs up before landing.
Saam Barati
Comment 3 2018-01-04 12:34:36 PST
Created attachment 330480 [details] patch for landing
Saam Barati
Comment 4 2018-01-04 12:35:19 PST
Created attachment 330481 [details] patch for landing Just fixing style stuff
Filip Pizlo
Comment 5 2018-01-04 15:34:59 PST
Comment on attachment 330481 [details] patch for landing still lgtm
WebKit Commit Bot
Comment 6 2018-01-04 16:01:37 PST
Comment on attachment 330481 [details] patch for landing Clearing flags on attachment: 330481 Committed r226426: <https://trac.webkit.org/changeset/226426>
WebKit Commit Bot
Comment 7 2018-01-04 16:01:38 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-01-04 16:05:55 PST
<rdar://problem/36308599>
Note You need to log in before you can comment on or make changes to this bug.