Bug 181295

Summary: Add commas
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ews-watchlist, rniwa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=180883
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 none

Keith Rollin
Reported 2018-01-04 10:39:49 PST
Fix a problem introduced in Bug 180883 where the emitted JSON didn't include some required commas.
Attachments
Patch (3.08 KB, patch)
2018-01-04 12:26 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (2.80 MB, application/zip)
2018-01-04 13:30 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Keith Rollin
Comment 1 2018-01-04 10:40:38 PST
<rdar://problem/35802295>
Keith Rollin
Comment 2 2018-01-04 12:26:47 PST
Created attachment 330478 [details] Patch
Brent Fulgham
Comment 3 2018-01-04 12:45:44 PST
Comment on attachment 330478 [details] Patch Commas are good. r=me.
EWS Watchlist
Comment 4 2018-01-04 13:21:09 PST
Attachment 330478 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:752: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:753: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:754: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:755: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:761: Missing space before { [whitespace/braces] [5] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 5 2018-01-04 13:30:35 PST
Comment on attachment 330478 [details] Patch Attachment 330478 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5928077 New failing tests: fast/mediastream/MediaStream-MediaElement-setObject-null.html
EWS Watchlist
Comment 6 2018-01-04 13:30:37 PST
Created attachment 330485 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
WebKit Commit Bot
Comment 7 2018-01-04 13:48:00 PST
Comment on attachment 330478 [details] Patch Clearing flags on attachment: 330478 Committed r226419: <https://trac.webkit.org/changeset/226419>
WebKit Commit Bot
Comment 8 2018-01-04 13:48:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.