Bug 181285

Summary: Use no-cache fetch mode when loading main documents with location.reload()
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: REOPENED ---    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, dbates, ews-watchlist, japhet, jlewis3, rniwa, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 183132    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews100 for mac-elcapitan
none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews117 for mac-elcapitan
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Patch
none
Patch
none
Updating test
none
Archive of layout-test-results from ews103 for mac-sierra none

Description youenn fablet 2018-01-04 05:01:02 PST
Use no-cache fetch mode when loading main documents with location.reload()
Comment 1 youenn fablet 2018-01-04 05:22:48 PST
Created attachment 330458 [details]
Patch
Comment 2 EWS Watchlist 2018-01-04 06:23:48 PST
Comment on attachment 330458 [details]
Patch

Attachment 330458 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5925417

New failing tests:
http/tests/navigation/statistics.html
http/tests/navigation/redirect-on-back-updates-history-item.html
http/tests/navigation/post-frames-goback1-uncached.html
http/tests/navigation/redirect-on-reload-updates-history-item.html
Comment 3 EWS Watchlist 2018-01-04 06:23:49 PST
Created attachment 330462 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 EWS Watchlist 2018-01-04 06:30:45 PST
Comment on attachment 330458 [details]
Patch

Attachment 330458 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5925423

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https.html
http/tests/navigation/post-frames-goback1-uncached.html
Comment 5 EWS Watchlist 2018-01-04 06:30:47 PST
Created attachment 330464 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 EWS Watchlist 2018-01-04 06:48:58 PST
Comment on attachment 330458 [details]
Patch

Attachment 330458 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5925438

New failing tests:
http/tests/navigation/statistics.html
http/tests/navigation/redirect-on-back-updates-history-item.html
http/tests/navigation/post-frames-goback1-uncached.html
http/tests/navigation/redirect-on-reload-updates-history-item.html
Comment 7 EWS Watchlist 2018-01-04 06:49:00 PST
Created attachment 330465 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 EWS Watchlist 2018-01-04 07:00:35 PST
Comment on attachment 330458 [details]
Patch

Attachment 330458 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5925489

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https.html
http/tests/navigation/post-frames-goback1-uncached.html
Comment 9 EWS Watchlist 2018-01-04 07:00:37 PST
Created attachment 330466 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 10 youenn fablet 2018-01-05 08:25:21 PST
Created attachment 330548 [details]
Patch
Comment 11 youenn fablet 2018-01-05 09:25:32 PST
Created attachment 330552 [details]
Patch
Comment 12 youenn fablet 2018-01-05 10:25:53 PST
Mac-32 bit failure is unrelated.
Comment 13 Radar WebKit Bug Importer 2018-01-08 12:47:34 PST
<rdar://problem/36356831>
Comment 14 WebKit Commit Bot 2018-01-08 13:06:53 PST
Comment on attachment 330552 [details]
Patch

Clearing flags on attachment: 330552

Committed r226531: <https://trac.webkit.org/changeset/226531>
Comment 15 WebKit Commit Bot 2018-01-08 13:06:55 PST
All reviewed patches have been landed.  Closing bug.
Comment 16 Ryan Haddad 2018-01-08 17:20:33 PST
This change appears to have caused LayoutTest http/tests/inspector/network/har/har-page.html to fail:
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r226581%20(6756)/results.html

I can reproduce the failure locally with a build of 226531, I cannot reproduce with 226528.
Comment 17 Matt Lewis 2018-01-09 15:00:53 PST
Reverted r226531 for reason:

This caused test failures on macOS WK2.

Committed r226659: <https://trac.webkit.org/changeset/226659>
Comment 18 youenn fablet 2018-01-10 02:30:36 PST
(In reply to Ryan Haddad from comment #16)
> This change appears to have caused LayoutTest
> http/tests/inspector/network/har/har-page.html to fail:
> https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/
> r226581%20(6756)/results.html
> 
> I can reproduce the failure locally with a build of 226531, I cannot
> reproduce with 226528.

Failure is 
           "cookies": [],
           "headers": "<filtered>",
           "content": {
-            "size": 3042,
+            "size": 0,
             "compression": 0,
             "mimeType": "text/html",
             "text": "<filtered text (3042)>"

size can be set to zero even if text is not empty in case of 304 responses I think.
I will change the test to filter the "size" parameter since cache may or may not contain those resources.
Comment 19 youenn fablet 2018-01-10 02:43:14 PST
Created attachment 330884 [details]
Updating test
Comment 20 WebKit Commit Bot 2018-01-10 11:48:54 PST
The commit-queue encountered the following flaky tests while processing attachment 330884 [details]:

The commit-queue is continuing to process your patch.
Comment 21 EWS Watchlist 2018-01-10 12:29:57 PST
Comment on attachment 330884 [details]
Updating test

Attachment 330884 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6023842

New failing tests:
http/tests/misc/slow-loading-animated-image.html
Comment 22 EWS Watchlist 2018-01-10 12:29:59 PST
Created attachment 330947 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 23 WebKit Commit Bot 2018-01-10 16:45:54 PST
Comment on attachment 330884 [details]
Updating test

Clearing flags on attachment: 330884

Committed r226745: <https://trac.webkit.org/changeset/226745>
Comment 24 WebKit Commit Bot 2018-01-10 16:45:56 PST
All reviewed patches have been landed.  Closing bug.
Comment 25 WebKit Commit Bot 2018-02-26 09:34:49 PST
Re-opened since this is blocked by bug 183132