Bug 181276

Summary:

Storage Access API: Remove JavaScript confirm() prompt from Document::requestStorageAccess()

Product:

WebKit

Reporter:

John Wilander <wilander>

Component:

WebCore Misc.

Assignee:

John Wilander <wilander>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer, wilander

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

John Wilander

Reported 2018-01-03 20:33:51 PST

This is an existing FIXME in the code. The JavaScript confirm() prompt has been there for demo purposes only.

Attachments
Patch (22.73 KB, patch) 2018-01-03 22:12 PST, John Wilander	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-01-03 20:34:16 PST

<rdar://problem/36290463>

John Wilander

Comment 2 2018-01-03 22:12:52 PST

Created attachment 330447 [details] Patch

Alex Christensen

Comment 3 2018-01-03 22:56:09 PST

Comment on attachment 330447 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330447&action=review > LayoutTests/ChangeLog:10 > + Two test cases are deleted since the user has no way > + to deny access through a prompt anymore. The rest Let's just skip them. They're still valuable tests, right? We can add plumbing to get them to work the new way.

John Wilander

Comment 4 2018-01-03 23:15:49 PST

(In reply to Alex Christensen from comment #3) > Comment on attachment 330447 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=330447&action=review > > > LayoutTests/ChangeLog:10 > > + Two test cases are deleted since the user has no way > > + to deny access through a prompt anymore. The rest > > Let's just skip them. They're still valuable tests, right? We can add > plumbing to get them to work the new way. I’m OK just skipping them but there is no reason to have them in this version of the feature. No prompt => no way for the user to deny access. The rest still applies, such as required user gesture.

Brent Fulgham

Comment 5 2018-01-04 09:05:52 PST

Comment on attachment 330447 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330447&action=review >>> LayoutTests/ChangeLog:10 >>> + to deny access through a prompt anymore. The rest >> >> Let's just skip them. They're still valuable tests, right? We can add plumbing to get them to work the new way. > > I’m OK just skipping them but there is no reason to have them in this version of the feature. No prompt => no way for the user to deny access. The rest still applies, such as required user gesture. I agree -- let's remove the tests and we can add some variant of them back if we decide we want to revisit prompting in the future.

John Wilander

Comment 6 2018-01-04 09:35:09 PST

Comment on attachment 330447 [details] Patch OK, committing as is. Alex, all the test infrastructure for prompt tests is still there.

WebKit Commit Bot

Comment 7 2018-01-04 09:57:00 PST

Comment on attachment 330447 [details] Patch Clearing flags on attachment: 330447 Committed r226409: <https://trac.webkit.org/changeset/226409>

WebKit Commit Bot

Comment 8 2018-01-04 09:57:02 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.