Bug 181259

Summary: Remove WebCore::IOSApplication::isWebApp()
Product: WebKit Reporter: David Quesada <david_quesada>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, darin, lingcherd_ho, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

David Quesada
Reported 2018-01-03 14:16:50 PST
This check isn't needed anymore since com.apple.webapp no longer uses WebKit directly. It is also subtly wrong since com.apple.webapp isn't the only bundle id where these hacks would have been needed. We should remove it.
Attachments
Patch (6.61 KB, patch)
2019-10-05 15:11 PDT, David Quesada 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Quesada
Comment 1 2019-10-05 15:11:27 PDT
Created attachment 380290 [details] Patch
WebKit Commit Bot
Comment 2 2019-10-14 16:24:08 PDT
Comment on attachment 380290 [details] Patch Clearing flags on attachment: 380290 Committed r251108: <https://trac.webkit.org/changeset/251108>
WebKit Commit Bot
Comment 3 2019-10-14 16:24:10 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4 2019-10-15 10:04:23 PDT
Comment on attachment 380290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380290&action=review > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:251 > // FIXME: Ideally we should just have Safari, WebApp, and webbookmarksd create a data store with A bit peculiar that this comment still mentions WebApp.
Ling Ho
Comment 5 2019-10-15 14:14:12 PDT
<rdar://problem/56269442>
Note You need to log in before you can comment on or make changes to this bug.