| Summary: | Fix the build on platforms where UICurrentUserInterfaceIdiomIsPad is defined to false | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, aestes, commit-queue, ews-watchlist, sam, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2018-01-02 12:30:55 PST
Created attachment 330328 [details]
Patch
Someone might have some idea about a better way. I started with #pragma disabling the warning, but it was in a lot of places which is kind of annoying. Attachment 330328 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1158: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 330328 [details] Patch Clearing flags on attachment: 330328 Committed r226335: <https://trac.webkit.org/changeset/226335> All reviewed patches have been landed. Closing bug. |