Bug 181188

Summary: [Attachment Support] Remove current macOS support for dragging file-backed attachments
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix Win/GTK builds none

Wenson Hsieh
Reported 2017-12-29 12:50:58 PST
No client (Mail included) currently exercises these codepaths. In subsequent patches, I'm reimplementing this feature in a way that is (1) compatible with dragging on iOS, and (2) is generalizable to non-file-backed blobs (i.e. Files that are created entirely via bindings, and thus have no references to file paths on the system).
Attachments
Patch (26.54 KB, patch)
2017-12-29 14:01 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix Win/GTK builds (28.08 KB, patch)
2017-12-29 14:43 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-12-29 14:01:44 PST
Created attachment 330258 [details] Patch
Wenson Hsieh
Comment 2 2017-12-29 14:43:01 PST
Created attachment 330259 [details] Fix Win/GTK builds
Wenson Hsieh
Comment 3 2017-12-30 11:09:37 PST
Comment on attachment 330259 [details] Fix Win/GTK builds Thanks Dan!
WebKit Commit Bot
Comment 4 2017-12-30 11:30:44 PST
Comment on attachment 330259 [details] Fix Win/GTK builds Clearing flags on attachment: 330259 Committed r226312: <https://trac.webkit.org/changeset/226312>
WebKit Commit Bot
Comment 5 2017-12-30 11:30:45 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-01-02 13:00:29 PST
<rdar://problem/36260924>
Note You need to log in before you can comment on or make changes to this bug.