Summary: | [WPE][GTK] Implement the assignment of ProcessIdentifiers to child processes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, clopez, commit-queue, don.olmstead, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Brady Eidson
2017-12-29 09:35:11 PST
It looks like we only have ProcessLauncherGLib and ProcessLauncherMac. I'll look into this for ProcessLauncherGLib, which covers the WPE and GTK ports. Those are the only upstream WK2 ports right now (asides the WIP Windows port) so I believe no other ports should need to be updated. (And thanks for filing the bug. ;) What about non-Glib and non-Cocoa ports like WinCairo? I guess this needs to be implemented there as well, doesn't it? (In reply to Carlos Alberto Lopez Perez from comment #3) > What about non-Glib and non-Cocoa ports like WinCairo? I guess this needs to > be implemented there as well, doesn't it? This is for WK2. Windows support is WIP, and I don't see a ProcessLauncherWin yet. Created attachment 330300 [details]
Patch
Comment on attachment 330300 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330300&action=review LGTM > Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:97 > + GUniquePtr<gchar> processIdentifier(g_strdup_printf("%" PRIu64, m_launchOptions.processIdentifier.toUInt64())); Whole patch is precisely what I tried to do blind except I had no way of verifying this line. :) Thanks! Comment on attachment 330300 [details] Patch Clearing flags on attachment: 330300 Committed r226327: <https://trac.webkit.org/changeset/226327> All reviewed patches have been landed. Closing bug. I broke the plugin process. Committed r226337: <https://trac.webkit.org/changeset/226337> |