Bug 181165

Summary: [JSC] Remove std::chrono completely
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, cdumez, cmarcelo, dbates, ews-watchlist, fpizlo, jfbastien, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch annulen: review+

Yusuke Suzuki
Reported 2017-12-26 15:13:30 PST
[JSC] Remove std::chrono completely
Attachments
Patch (40.98 KB, patch)
2017-12-26 15:24 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (41.50 KB, patch)
2017-12-26 16:09 PST, Yusuke Suzuki 		annulen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-12-26 15:24:04 PST
Created attachment 330204 [details] Patch
EWS Watchlist
Comment 2 2017-12-26 15:26:50 PST
Attachment 330204 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:389: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Konstantin Tokarev
Comment 3 2017-12-26 16:01:09 PST
Comment on attachment 330204 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330204&action=review > Source/JavaScriptCore/runtime/Watchdog.cpp:41 > + , m_wallClockDeadline(MonotonicTime::infinity()) This variable doesn't hold wall clock time anymore > Source/JavaScriptCore/runtime/Watchdog.cpp:135 > + auto wallClockTime = MonotonicTime::now(); Ditto
Yusuke Suzuki
Comment 4 2017-12-26 16:05:22 PST
Comment on attachment 330204 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330204&action=review >> Source/JavaScriptCore/runtime/Watchdog.cpp:41 >> + , m_wallClockDeadline(MonotonicTime::infinity()) > > This variable doesn't hold wall clock time anymore Fixed. Even before this patch, it was not wall clock since we used std::chrono::steady_clock. >> Source/JavaScriptCore/runtime/Watchdog.cpp:135 >> + auto wallClockTime = MonotonicTime::now(); > > Ditto Fixed.
Yusuke Suzuki
Comment 5 2017-12-26 16:09:11 PST
Created attachment 330205 [details] Patch
EWS Watchlist
Comment 6 2017-12-26 16:10:57 PST
Attachment 330205 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:389: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Konstantin Tokarev
Comment 7 2017-12-26 16:22:57 PST
Comment on attachment 330205 [details] Patch r=me it seems like CLOCK_THREAD_CPUTIME_ID is available on other BSDs too, maybe it makes sense to broaden condition
Yusuke Suzuki
Comment 8 2017-12-26 16:33:17 PST
Committed r226295: <https://trac.webkit.org/changeset/226295>
Radar WebKit Bug Importer
Comment 9 2018-01-02 12:59:13 PST
<rdar://problem/36260885>
Note You need to log in before you can comment on or make changes to this bug.