Bug 181143

Summary: [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz, rniwa, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated bug title none

Wenson Hsieh
Reported 2017-12-22 23:24:20 PST
Don't make attachment elements for images with https:, http: or data: urls. Clients such as Mail would expect pasting or dropping an image with src="https://..." to result in the source URL being preserved (i.e. staying as remote images) instead of creating image attachments out of them.
Attachments
Patch (13.83 KB, patch)
2017-12-22 23:35 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Updated bug title (13.83 KB, patch)
2017-12-23 01:11 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-12-22 23:25:07 PST
<rdar://problem/36200381>
Wenson Hsieh
Comment 2 2017-12-22 23:35:36 PST
Created attachment 330159 [details] Patch
Wenson Hsieh
Comment 3 2017-12-23 01:11:20 PST
Created attachment 330160 [details] Updated bug title
Wenson Hsieh
Comment 4 2018-01-02 15:46:16 PST
Comment on attachment 330160 [details] Updated bug title Thanks for the review!
WebKit Commit Bot
Comment 5 2018-01-02 16:06:45 PST
Comment on attachment 330160 [details] Updated bug title Clearing flags on attachment: 330160 Committed r226340: <https://trac.webkit.org/changeset/226340>
WebKit Commit Bot
Comment 6 2018-01-02 16:06:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.