Bug 181140

Summary:

computeTextPaintStyle() does not need to know about frame

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Layout and Rendering

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

bfulgham, koivisto, pvollan, simon.fraser, zalan

Priority:

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	dbates: review-

Description Daniel Bates 2017-12-22 14:59:43 PST

computeTextPaintStyle() should take the viewport size instead of a frame as it is unnecessary for it to know about a frame.

Comment 1 Daniel Bates 2017-12-22 15:05:47 PST

Created attachment 330148 [details]
Patch

Comment 2 Daniel Bates 2017-12-22 15:14:38 PST

Comment on attachment 330148 [details]
Patch

r-, this won't work :( we need the frame to also query for the focus controller and to query the document if it is printing

Comment 3 Daniel Bates 2017-12-22 15:28:17 PST

One way to fix this is to have computeTextPaintStyle() take individual arguments for whether the document is printing, whether we should print backgrounds and whether the page is currently focused. This does not sound like a big improvement.