Summary: | REGRESSION(r218089): [GTK] webkit_web_view_get_inspector() needs to be called, otherwise inspector does not close | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cédric Bellegarde <cedric.bellegarde> | ||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aperez, bugs-noreply, cgarcia, clopez, inspector-bugzilla-changes, mcatanzaro, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Cédric Bellegarde
2017-12-22 07:41:12 PST
This one, I can reproduce. 2.18.3 is fine, trunk is not. We could probably fix it by calling webkitWebInspectorCreate during WebKitWebView construction, instead of doing it lazily, but there's probably a better way, if we could figure out what changed here. I can't reproduce this. (In reply to Carlos Garcia Campos from comment #3) > I can't reproduce this. Did you try the example in the first comment? MiniBrowser and epiphany both calls webkit_web_view_get_inspector(), which avoids the problem, so you won't be able to reproduce there. Created attachment 335176 [details]
Patch
I can reproduce this with Dinghy (https://github.com/aperezdc/dinghy), which is is a WPE launcher/browser. It can be built with against WebKitGTK+ as well passing “-DDY_USE_WEBKITGTK=ON” to CMake. The issue is present in both ports. Committed r229396: <https://trac.webkit.org/changeset/229396> |