Bug 18109 – Implement hanging punctuation

• Component: Layout and Rendering
• Status: NEW

[Nicholas Shanks]

The css3-text module is going nowhere fast, and it's hanging-punctuation declaration is so ill-defined that I can't even figure out what the values mean.

Since WebKit is the typographical tiger of the web world, we should come up with something awesome that works for all scripts and locales, which we can submit to the CSS WG.

[Dave Hyatt]

Agree 100%.  I've wanted this feature for a while (even if it's just opt-in through a new property).

[Daniel]

Any news on this? I checked W3C's specifications and it seems like they don't know how to implement it in a code either. But this would be so useful for any web designer, since, let's admit it, punctuation within the content box at the start of a paragraph really does suck. We need Webkit to lead the way on this, as you guys often do! :)

Just wanted to bring this up since the last post on this feature request goes back to 2008.

[Dave Hyatt]

Created attachment 270594 [details]
Patch

[WebKit Commit Bot]

Attachment 270594 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSPrimitiveValueMappings.h:1634:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/CSSParser.cpp:10536:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 270595 [details]
Patch

[Dave Hyatt]

Initial parsing landed in r196075.

[Brent Fulgham]

It doesn't seem like other browsers implemented this.

[Sebastian Zartner]

For what it's worth, the hanging-punctuation property is currently defined at https://drafts.csswg.org/css-text-3/#hanging-punctuation-property.

Sebastian

[Rehan Butt]

Not sure if this is the right place for this but looks like `hanging-punctuation` in Safari is inconsistent and not sure why. For reference here are 2 code snippets 1 that works and 1 that does not.

Not Working - https://codepen.io/rehanbutt/pen/raVgbag
Working - https://codepen.io/rehanbutt/pen/GgJaLqv

[alan]

WebKit does not recognize U+0022 as candidate for hanging-punctuation (U+201C works fine) and same for single quotation mark (see U_GET_GC_MASK(leadingCharacter) & (U_GC_PS_MASK | U_GC_PI_MASK | U_GC_PF_MASK)).
I need to check if this regressed when WebKit enabled their modern inline layout, and if not, I am curious if git history has some explanation of why.