Summary: | Clean up context menu code | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | berto, bfulgham, cgarcia, ews-watchlist, gustavo, mcatanzaro, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Alex Christensen
2017-12-20 19:00:45 PST
Created attachment 329993 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Created attachment 329997 [details]
Patch
Created attachment 330001 [details]
Patch
Created attachment 330002 [details]
Patch
Created attachment 330004 [details]
Patch
Comment on attachment 330004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330004&action=review Nice cleanup! r=me. > Source/WebKit/ChangeLog:10 > + Remove dead iOS code. Reduce allocations. Add stub for WPE. Yay! > Source/WebKit/UIProcess/WebPageProxy.cpp:4732 > + m_activeContextMenu = m_pageClient.createContextMenuProxy(*this, WTFMove(contextMenuContextData), userData); Is it okay to move 'contextMenuContextData' here, after also assigning it above? I guess the assignment is copying, so never mind. |