Bug 181055

Summary: webkitpy: simctl cannot handle partial runtime version matches
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, commit-queue, ews-watchlist, glenn, krollin, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2017-12-20 14:00:17 PST
simctl should be able to handle partial runtime version matches. For example, a runtime for iOS 11.0.1 should match a request for an iOS 11 runtime.
Attachments
Patch (1.68 KB, patch)
2017-12-20 14:16 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (4.34 KB, patch)
2017-12-20 15:59 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-12-20 14:00:46 PST
<rdar://problem/36163798>
Jonathan Bedard
Comment 2 2017-12-20 14:16:28 PST
Created attachment 329953 [details] Patch
Keith Rollin
Comment 3 2017-12-20 14:47:12 PST
WFM
Alexey Proskuryakov
Comment 4 2017-12-20 15:43:17 PST
Comment on attachment 329953 [details] Patch It seems worth having some regression tests (both positive and negative matches).
Jonathan Bedard
Comment 5 2017-12-20 15:45:02 PST
(In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 329953 [details] > Patch > > It seems worth having some regression tests (both positive and negative > matches). I will add some tests. Generally, this behavior is already pretty well tested in webkitpy/common/version_unittest.py.
Jonathan Bedard
Comment 6 2017-12-20 15:59:15 PST
Created attachment 329961 [details] Patch
WebKit Commit Bot
Comment 7 2017-12-20 20:37:58 PST
Comment on attachment 329961 [details] Patch Clearing flags on attachment: 329961 Committed r226214: <https://trac.webkit.org/changeset/226214>
WebKit Commit Bot
Comment 8 2017-12-20 20:38:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.