Bug 181042

Summary: Do not reuse resource for memory cache if selected service worker differs
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Service WorkersAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, dbates, ews-watchlist, ggaren, japhet, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch youennf: review+

Chris Dumez
Reported 2017-12-20 09:32:46 PST
Do not reuse resource for memory cache if selected service worker differs.
Attachments
Patch (6.10 KB, patch)
2017-12-20 09:38 PST, Chris Dumez 		youennf: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-12-20 09:38:20 PST
Created attachment 329926 [details] Patch
youenn fablet
Comment 2 2017-12-20 10:10:39 PST
Comment on attachment 329926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329926&action=review > Source/WebCore/loader/cache/CachedResourceLoader.cpp:1028 > + if (cachedResourceRequest.options().serviceWorkerIdentifier != existingResource->options().serviceWorkerIdentifier) { I think we should add a comment or a FIXME to state that this area is under specified and that we should try specificying/validating this with other browsers. Now it feels safer to do that to limit weird bugs/flakinesses.
Chris Dumez
Comment 3 2017-12-20 10:30:11 PST
Committed r226188: <https://trac.webkit.org/changeset/226188>
Radar WebKit Bug Importer
Comment 4 2017-12-20 10:32:26 PST
<rdar://problem/36158813>
Note You need to log in before you can comment on or make changes to this bug.