Bug 181037
| Summary: | Refactor RenderMathMLMenclose to remove LayoutRect member modified during layout | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> |
| Component: | MathML | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | alex, jfernandez, lambda, rego |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=161126 | ||
| Bug Depends on: | 180348 | ||
| Bug Blocks: | |||
Frédéric Wang (:fredw)
fred@igalia-fwang:~/webkit/WebKit$ grep m_ Source/WebCore/rendering/mathml/RenderMathMLMenclose.h
LayoutRect m_contentRect;
This is similar to bug 180151. We can probably refactor the code so that we don't need m_contentRect. The RenderMathMLRow::getContentBoundingBox function introduced in bug 180348 should help to do it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Minsheng Liu
Is this really necessary? If we decide to introduce a const method to replace m_contentRect, then we need to recompute the content bounding box every time we paint, which seems quite costly to me. How about caching the content bounding box in RenderMathMLRow so that we do not need to cache it twice? That seems more manageable.