Bug 181035

Summary: Support service worker interception of request with blob body
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, ews-watchlist, ggaren, mmaxfield, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
none
Patch for landing none

youenn fablet
Reported 2017-12-20 08:04:58 PST
Support service worker interception of request with blob body
Attachments
Patch (20.04 KB, patch)
2017-12-20 08:08 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (2.57 MB, application/zip)
2017-12-20 09:19 PST, EWS Watchlist 		no flags
Details
Patch for landing (21.99 KB, patch)
2017-12-20 10:43 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-12-20 08:08:53 PST
Created attachment 329921 [details] Patch
EWS Watchlist
Comment 2 2017-12-20 09:19:31 PST
Comment on attachment 329921 [details] Patch Attachment 329921 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5774711 New failing tests: fast/mediastream/MediaStream-MediaElement-setObject-null.html
EWS Watchlist
Comment 3 2017-12-20 09:19:32 PST
Created attachment 329925 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
youenn fablet
Comment 4 2017-12-20 10:07:25 PST
Comment on attachment 329921 [details] Patch Test failure is unrelated.
Chris Dumez
Comment 5 2017-12-20 10:14:47 PST
Comment on attachment 329921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329921&action=review > Source/WebKit/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:74 > +void NetworkBlobRegistry::registerBlobURL(NetworkConnectionToWebProcess* connection, const WebCore::URL& url, const WebCore::URL& srcURL, bool bypassConnectionCheck) Coding style says we need a prefix for such boolean variables, maybe shouldBypassConnectionCheck ?
youenn fablet
Comment 6 2017-12-20 10:43:05 PST
Created attachment 329933 [details] Patch for landing
youenn fablet
Comment 7 2017-12-20 10:43:39 PST
(In reply to Chris Dumez from comment #5) > Comment on attachment 329921 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329921&action=review > > > Source/WebKit/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:74 > > +void NetworkBlobRegistry::registerBlobURL(NetworkConnectionToWebProcess* connection, const WebCore::URL& url, const WebCore::URL& srcURL, bool bypassConnectionCheck) > > Coding style says we need a prefix for such boolean variables, maybe > shouldBypassConnectionCheck ? Done in landing patch.
WebKit Commit Bot
Comment 8 2017-12-20 11:16:14 PST
Comment on attachment 329933 [details] Patch for landing Clearing flags on attachment: 329933 Committed r226191: <https://trac.webkit.org/changeset/226191>
WebKit Commit Bot
Comment 9 2017-12-20 11:16:16 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-12-20 11:18:46 PST
<rdar://problem/36160201>
Note You need to log in before you can comment on or make changes to this bug.