| Summary: | Support service worker interception of request with blob body | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | beidson, cdumez, commit-queue, ews-watchlist, ggaren, mmaxfield, rniwa, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2017-12-20 08:04:58 PST
Created attachment 329921 [details]
Patch
Comment on attachment 329921 [details] Patch Attachment 329921 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5774711 New failing tests: fast/mediastream/MediaStream-MediaElement-setObject-null.html Created attachment 329925 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 329921 [details]
Patch
Test failure is unrelated.
Comment on attachment 329921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329921&action=review > Source/WebKit/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:74 > +void NetworkBlobRegistry::registerBlobURL(NetworkConnectionToWebProcess* connection, const WebCore::URL& url, const WebCore::URL& srcURL, bool bypassConnectionCheck) Coding style says we need a prefix for such boolean variables, maybe shouldBypassConnectionCheck ? Created attachment 329933 [details]
Patch for landing
(In reply to Chris Dumez from comment #5) > Comment on attachment 329921 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329921&action=review > > > Source/WebKit/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:74 > > +void NetworkBlobRegistry::registerBlobURL(NetworkConnectionToWebProcess* connection, const WebCore::URL& url, const WebCore::URL& srcURL, bool bypassConnectionCheck) > > Coding style says we need a prefix for such boolean variables, maybe > shouldBypassConnectionCheck ? Done in landing patch. Comment on attachment 329933 [details] Patch for landing Clearing flags on attachment: 329933 Committed r226191: <https://trac.webkit.org/changeset/226191> All reviewed patches have been landed. Closing bug. |